Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for L1T EtSums of type kZDC{P,M} as trigger objects at HLT [13_2_X] #42708

Merged
merged 1 commit into from
Sep 4, 2023
Merged

add support for L1T EtSums of type kZDC{P,M} as trigger objects at HLT [13_2_X] #42708

merged 1 commit into from
Sep 4, 2023

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Sep 2, 2023

backport of #42707

PR description:

This PR adds support for L1T EtSums of type kZDC{P,M} as trigger objects at HLT. These new types were introduced in #42634 (L1T-ZDC emulation).

Two types, trigger::TriggerL1ZDC{P,M}, are added to TriggerTypeDefs.h, and support for them is added to the plugin HLTL1TSeed (which puts L1T objects into the edm::Event as part of the TriggerFilterObjectWithRefs data format).

A similar update was done in #36951 to support the L1T data formats for "MuonShowers". One difference in this PR is that the underlying data format, i.e. l1t::EtSum, is not a new one (unlike l1t::MuonShower was), and this makes the changes on the HLT side less extensive compared to #36951.

Note: the edm::InputTag added to HLTL1TSeed in this PR will point to a non-existing collection in the current HLT menus until an unpacker for the ZDC inputs to the L1T-uGT is added to CMSSW (see #42634 (comment)). For this reason, only a LogDebug message is issued when this collection is missing, and eventually this should be replaced by a edm::LogWarning (once the unpacker is available).

No changes expected.

Requires #42706.

PR validation:

None.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#42707

HLT software for 2023 (and beyond ?).

@cmsbuild cmsbuild added this to the CMSSW_13_2_X milestone Sep 2, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2023 •
edited
Loading

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_2_X.

It involves the following packages:

  • DataFormats/HLTReco (hlt)
  • HLTrigger/HLTfilters (hlt)

@cmsbuild, @missirol, @mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @rovere this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented Sep 2, 2023

test parameters:

@missirol
Copy link
Contributor Author

missirol commented Sep 2, 2023

urgent

@cms-sw/orp-l2 , this is to signal that HLT would like to have this PR included in the next 13_2_X release.

@cmsbuild cmsbuild added the urgent label Sep 2, 2023
@missirol
Copy link
Contributor Author

missirol commented Sep 2, 2023

please test

@missirol missirol mentioned this pull request Sep 2, 2023
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b738c3/34584/summary.html
COMMIT: a40eda1
CMSSW: CMSSW_13_2_X_2023-09-01-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42708/34584/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3197913
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3197885
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6e77734 into cms-sw:CMSSW_13_2_X Sep 4, 2023
@missirol missirol deleted the devel_hltL1TSeedEtSumZDC_132X branch September 4, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport fully-signed hlt-approved orp-approved requires-external tests-approved urgent
Projects
None yet
Milestone
CMSSW_13_2_X
Development

Successfully merging this pull request may close these issues.
4 participants
@missirol @cmsbuild @Martin-Grunewald @antoniovilela